Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added RowBuilder widget documentation #5206

Merged
merged 5 commits into from
Aug 26, 2019
Merged

Added RowBuilder widget documentation #5206

merged 5 commits into from
Aug 26, 2019

Conversation

serhiyzhovnir
Copy link
Contributor

@serhiyzhovnir serhiyzhovnir commented Aug 19, 2019 •
edited by jeff-matthews
Loading

Purpose of this pull request

This pull request (PR) adds documentation about the RowBuilder widget.

Affected DevDocs pages

This documentation will have the following links:

Page look:
RowBuilder doc page

Links to Magento source code

whatsnew
Added a new topic about the RowBuilder widget.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Aug 19, 2019
rogyar
rogyar suggested changes Aug 19, 2019
View reviewed changes
@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Major Update Significant original updates to existing content Technical Updates to the code or processes that alter the technical content of the doc and removed Major Update Significant original updates to existing content labels Aug 19, 2019
@rogyar
Copy link
Contributor

rogyar commented Aug 19, 2019

Hi @serhiyzhovnir. Thank you for the great topic. Please, perform a few minor adjustments and we are good to go.

@serhiyzhovnir
Copy link
Contributor Author

Hi @rogyar
The PR was adjusted. Please, review it again.
Thank you!

jeff-matthews
jeff-matthews suggested changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new topic @serhiyzhovnir! I made some minor editorial suggestions.

@serhiyzhovnir
Copy link
Contributor Author

Hi @jeff-matthews
The PR was adjusted.
Thank you!

jeff-matthews
jeff-matthews approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @serhiyzhovnir!

jeff-matthews
jeff-matthews suggested changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiyzhovnir, I just noticed some markdown syntax errors in your branch that will fail tests. Please fix these issues so I can finish processing:

 rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/javascript-dev-guide/widgets/widget-row-builder.md:44: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget-row-builder.md:44: MD009 Trailing spaces

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

The Markdown linter has found 4 issues

@serhiyzhovnir
Copy link
Contributor Author

Hi @jeff-matthews
The trailing spaces were removed.
Please, check the PR again.
Thank you!

jeff-matthews
jeff-matthews approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Thanks @serhiyzhovnir!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit f9abc7b into magento:master Aug 26, 2019
@ghost
Copy link

ghost commented Aug 26, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@serhiyzhovnir serhiyzhovnir mentioned this pull request Sep 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@rogyar rogyar rogyar approved these changes

@jeff-matthews jeff-matthews jeff-matthews approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rogyar rogyar

@jeff-matthews jeff-matthews

Labels
2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiyzhovnir @devops-devdocs @rogyar @jeff-matthews @magento-engcom-team